Skip to content

feat: implement issue #140 — Compliance: non-stub-dependabot-automerge.yml - #514

Merged
don-petry merged 10 commits into
mainfrom
dev-lead/issue-140-20260609-2057
Jun 10, 2026
Merged

don-petry merged 10 commits into
mainfrom
dev-lead/issue-140-20260609-2057

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

Closes #140

Implemented by dev-lead agent. Please review.

@don-petry
don-petry requested a review from a team as a code owner June 9, 2026 21:01
Copilot AI review requested due to automatic review settings June 9, 2026 21:01
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 20 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e64b3ec8-c578-49fc-9b1e-9416cd3b3810

📥 Commits

Reviewing files that changed from the base of the PR and between e5e6285 and 141f0df.

📒 Files selected for processing (1)
  • .github/workflows/dependabot-automerge.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-140-20260609-2057

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR brings the repository’s Dependabot auto-merge workflow stub back into compliance with org standards for centralized reusable workflows (Issue #140), by ensuring the reusable workflow reference is version-tag pinned.

Changes:

  • Update the uses: reference in the Dependabot auto-merge thin-caller workflow to point to petry-projects/.github/...@v1 (org-standard pin), replacing a commit-SHA reference.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 9, 2026 21:04
@don-petry
don-petry disabled auto-merge June 9, 2026 21:04
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 1 — Quality Gate passed comment (0 new issues, 0 security hotspots; no actionable findings and no open review threads to resolve)
```
The SonarQube comment is purely a status notification. With no open threads, no actionable findings in the comment, no hotspot patterns in the changed file, and no Tier 1 blockers anywhere, this PR requires no code changes.

@don-petry
don-petry enabled auto-merge (squash) June 9, 2026 21:05
@don-petry
don-petry disabled auto-merge June 9, 2026 21:14
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 9, 2026 21:15
@don-petry
don-petry disabled auto-merge June 9, 2026 21:24
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 1 (Quality Gate passed — no new issues, no hotspots, no open threads)
Remaining Tier 1 blocker (not code-fixable):
  - "review" job failure: DON_PETRY_BOT_GH_PAT is a fine-grained PAT;
    must be replaced with a classic PAT (repo + workflow + read:org scopes)
    by an org admin in GitHub secrets settings.
```

@don-petry
don-petry enabled auto-merge (squash) June 9, 2026 21:25
@don-petry
don-petry disabled auto-merge June 9, 2026 21:35
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 0
Notes:
- SonarQube Quality Gate PASSED — 0 new issues, 0 security hotspots, 0 duplication.
  No open review threads from sonarqubecloud[bot] exist on this PR.
  No actionable hotspot patterns found in the changed file
  (.github/workflows/dependabot-automerge.yml — YAML only, no shell execution,
  no HTTP downloads, no hardcoded credentials).
Tier 1 blocker (not code-fixable):
- review / review: FAILED — Fine-grained PAT detected.
  Error: "Fine-grained PAT detected — fine-grained PATs are not supported by this workflow.
  Replace DON_PETRY_BOT_GH_PAT with a classic PAT that has repo, workflow, and read:org scopes."
  This requires a repository admin to rotate the DON_PETRY_BOT_GH_PAT secret in
  org/repo settings — it cannot be addressed via a code change.
```
The SonarQube findings are all-green with nothing to address. The only failing check (`review / review`) is a secret configuration problem: `DON_PETRY_BOT_GH_PAT` is a fine-grained PAT but the PR review workflow requires a classic PAT with `repo`, `workflow`, and `read:org` scopes. A repository admin needs to rotate that secret.

@don-petry
don-petry enabled auto-merge (squash) June 9, 2026 21:36
@don-petry
don-petry disabled auto-merge June 9, 2026 23:57
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 9, 2026 23:59
@don-petry
don-petry disabled auto-merge June 10, 2026 00:02
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 0
Tier 1 blocker (review / review): pre-existing infrastructure issue — DON_PETRY_BOT_GH_PAT
  secret is a fine-grained PAT; verify-auth-scopes.sh:37-44 hard-fails on fine-grained PATs.
  Requires replacing the secret with a classic PAT (repo + read:org scopes) in GitHub settings.
  Not addressable via code changes on this PR.
```

@don-petry
don-petry enabled auto-merge (squash) June 10, 2026 02:00
@don-petry
don-petry disabled auto-merge June 10, 2026 02:08
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 1 — Quality Gate passed with 0 new issues and 0 security
  hotspots; no open inline review threads from this bot exist; no SonarQube
  hotspot patterns found in the PR's changed files
```
No code changes, thread replies, or thread resolutions are needed. The PR is unblocked from a SonarCloud perspective.

@don-petry
don-petry enabled auto-merge (squash) June 10, 2026 02:09

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: MEDIUM
Reviewed commit: cdef884e18e75cfa4ca2e9affed7852ecbf5c5ab
Cascade: triage → deep (triage: haiku 4.5 → deep: sonnet 4.6 + duck: o4-mini → audit: opus 4.7)

Summary

PR changes the uses: pin in dependabot-automerge.yml from a SHA to @v1, directly implementing compliance audit issue #140. Triage flagged SHA removal as a CLAUDE.md violation, but AGENTS.md explicitly exempts first-party org reusable workflows from the SHA-pinning standard, and the compliance audit itself mandates @v1 as the org canonical form. All CI checks pass, the stub structure is fully preserved, and no security concerns were found.

Findings

  • INFO: Change is mandated by automated compliance audit issue #140. The org canonical stub (standards/workflows/dependabot-automerge.yml) uses @v1; switching from the SHA pin to @v1 brings this file into verbatim conformance.
  • INFO: AGENTS.md §'Release channel tags & the mutable-ref exception' explicitly exempts first-party org reusable workflows from the SHA-pin standard. petry-projects/.github is org-owned, so @v1 on this ref is the documented accepted pattern.
  • MINOR: PR title says 'non-stub-dependabot-automerge.yml', which reads as converting the file to a non-stub. The 'non-stub' token is actually the compliance check ID from the audit. The file remains a valid thin caller stub after the change.
  • INFO: All CI checks pass: SonarCloud Quality Gate (0 new issues, 0 hotspots), CodeQL (actions + python), AgentShield, gitleaks secret scan, shellcheck, bats, unit-tests, agent-profile validation. review/review is the current pipeline run (IN_PROGRESS, expected). dependabot-automerge job SKIPPED correctly (not a Dependabot PR).
  • INFO: Workflow header reads 'MUST NOT change: the uses: line'. This PR modifies the version ref within that line. The restriction is intended to prevent calling a different reusable workflow; the reusable target is unchanged. Compliance audit authority supersedes this note for canonical-stub alignment changes.

Reviewed by the PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: o4-mini → audit: opus 4.7). Reply if you need a human review.

@don-petry
don-petry disabled auto-merge June 10, 2026 02:19
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #514
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-10T02:49:36Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-10T02:49:36Z

@don-petry
don-petry enabled auto-merge (squash) June 10, 2026 02:19
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry merged commit 0f4d894 into main Jun 10, 2026
25 checks passed
@don-petry
don-petry deleted the dev-lead/issue-140-20260609-2057 branch June 10, 2026 02:27

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: MEDIUM
Reviewed commit: 141f0dfc7851946b2638281060110b6011f71e70
Cascade: triage → deep (triage: haiku 4.5 → deep: sonnet 4.6 + duck: o4-mini → audit: opus 4.7)

Summary

PR removes the SHA pin on petry-projects/.github's dependabot-automerge-reusable.yml, replacing it with @v1 as required by compliance audit issue #140. Triage correctly identified the SHA removal but missed the documented first-party exemption in AGENTS.md §'Release channel tags & the mutable-ref exception', which explicitly states the SHA-pin standard targets third-party actions and does not apply to org-owned reusable workflows. All CI checks pass, the stub structure is fully preserved, advisory bots found no issues, and this is the sixth-week-old compliance finding with clear remediation authority.

Findings

  • INFO: Change is directly mandated by compliance audit issue #140 (opened 2026-05-12, open for ~4 weeks before this PR). The issue explicitly requires replacing the SHA pin with @v1 to match the org canonical stub at standards/workflows/dependabot-automerge.yml. (.github/workflows/dependabot-automerge.yml:39)
  • INFO: Triage flagged SHA removal as a CLAUDE.md violation, but AGENTS.md §'Release channel tags & the mutable-ref exception' explicitly exempts first-party org reusable workflows from the SHA-pin standard. The target petry-projects/.github is an org-owned repo; @v1 on it is the documented accepted pattern, not a supply-chain risk. (.github/workflows/dependabot-automerge.yml:39)
  • INFO: All CI checks pass at head SHA 141f0df: SonarCloud (0 new issues, 0 hotspots), CodeQL (actions + python), AgentShield, shellcheck, bats, unit-tests, agent-profile validation, gitleaks secret scan, Agent Security Scan. dependabot-automerge job correctly SKIPPED (not a Dependabot PR).
  • INFO: Commits since prior review SHA (cdef884) are all merge-from-main commits only — no substantive code changes since the prior cascade approval. The actual code change is the same single-line @SHA->#@v1 substitution reviewed in the prior cycle.
  • MINOR: The workflow header comment says 'You MUST NOT change: ... the uses: line'. This instruction is intended to prevent callers from routing to a different reusable workflow. The compliance audit supersedes this note for canonical-stub alignment: the reusable target is unchanged, only the version ref format is corrected. No structural drift. (.github/workflows/dependabot-automerge.yml)

Reviewed by the PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: o4-mini → audit: opus 4.7). Reply if you need a human review.

don-petry added a commit that referenced this pull request Jun 12, 2026
…e.yml (#514)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 13, 2026
…e.yml (#514)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 14, 2026
…e.yml (#514)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 18, 2026
…e.yml (#514)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 21, 2026
…e.yml (#514)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 23, 2026
…e.yml (#514)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 23, 2026
…e.yml (#514)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 23, 2026
…e.yml (#514)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Jun 23, 2026
…e.yml (#514)

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: non-stub-dependabot-automerge.yml

3 participants